CIV-15565 fix names for companies or organization #4848
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laarmada
requested review from
dharmendrak and
AbuSalamHMCTS
and removed request for
a team
ss-evoco
previously approved these changes
Oct 22, 2024
| party = claim.applicant1; | ||
| } | ||
| return party.partyDetails.title + ' ' + party.partyDetails.firstName + ' ' + party.partyDetails.lastName; | ||
| return claim.caseRole == CaseRole.CLAIMANT ? claim.getClaimantFullName() : claim.getDefendantFullName(); |
There was a problem hiding this comment.
Should we not be sending the defendant name if claimant does the RRF and vice versa ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
Request for reconsideration pages not replacing Claimant LR name
Change description
we are not covering when the claimant or defendant are companies or organization —> haven't: title + name +lastname.
Does this PR introduce a breaking change? (check one with "x")