Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FACT-1897 moved paymentsEnabled to values.yaml #3325

Merged
merged 5 commits into from
Sep 9, 2024
Merged

FACT-1897 moved paymentsEnabled to values.yaml #3325

merged 5 commits into from
Sep 9, 2024

Conversation

justiceia
Copy link
Contributor

@justiceia justiceia commented Aug 19, 2024

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/FACT-1897

Change description

moved hard coded values to values.yaml

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@justiceia justiceia self-assigned this Aug 19, 2024
Copy link
Contributor

@RuthKirby RuthKirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a comment about the default values on the variables. Also we may want to move PAYMENTS_ENABLED_PRIVATELAW: "false" to be next to these new ones.

src/main/resources/application-dev.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@RuthKirby RuthKirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the dollar signs outside of the curly braces so this:{$PAYMENTS_ENABLED_DIVORCE:false} becomes this ${PAYMENTS_ENABLED_DIVORCE:false} :)

@justiceia justiceia merged commit 99fa80c into master Sep 9, 2024
5 checks passed
@justiceia justiceia deleted the FACT-1897 branch September 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants