-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FACT-1897 moved paymentsEnabled to values.yaml #3325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a comment about the default values on the variables. Also we may want to move PAYMENTS_ENABLED_PRIVATELAW: "false" to be next to these new ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move the dollar signs outside of the curly braces so this:{$PAYMENTS_ENABLED_DIVORCE:false} becomes this ${PAYMENTS_ENABLED_DIVORCE:false} :)
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/FACT-1897
Change description
moved hard coded values to values.yaml
Does this PR introduce a breaking change? (check one with "x")