This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Throw a custom exception if calling provided transformer throws an exception #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgonczar
reviewed
Jul 8, 2019
| try { | ||
| result = transformer.transform(req.exceptionRecord); | ||
| } catch (Exception exc) { | ||
| throw new TransformationException("Error while calling provided transformer", exc); |
Contributor
There was a problem hiding this comment.
It might be worth phrasing it in such way that it's obvious that it's the transformer that threw the exception.
lgonczar
approved these changes
Jul 8, 2019
nitinprabhu
approved these changes
Jul 8, 2019
nitinprabhu
reviewed
Jul 8, 2019
| try { | ||
| result = transformer.transform(req.exceptionRecord); | ||
| } catch (Exception exc) { | ||
| throw new TransformationException( |
Contributor
There was a problem hiding this comment.
just wondering what will caseworker see on the screen whole exception stack trace unless services implement an exception handler ?
Contributor
Author
There was a problem hiding this comment.
in case of Spring Boot, it depends whether the default 500 response is something CCD will be able to 'parse'.
Contributor
There was a problem hiding this comment.
As far as I know, CCD displays a standard error message in such case.
rkondratowicz
deleted the
feature/throw-a-custom-exception-if-transformation-fails
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.