Skip to content

Conversation

mattnayler
Copy link
Contributor

@mattnayler mattnayler commented Sep 22, 2025

Jira link

DTSAM-1037 "Create utility classes to help simplify Drool Judicial Access Profile processing"

Change description

Create utility functions to simplify and standardise elements of the judicial mappings:

  • Match on Appointment codes (via enums, including possible multiple values)
  • Match on Additional Role codes (via enums, including possible multiple values)
  • Appointment Type / Contract Type: utility function to match on Salaried and SPTW together to ensure we always match on both options (i.e. add isSalaired, isFeePaid and isVoluntary)
  • Appointment EndDate
  • Authorisation EndDate and ServiceCode, wrap existing validate function to allow switch to using an enum with group of codes.

NB: This PR is branched from the ET feature branch in PR: #2477.

Testing done

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@mattnayler mattnayler marked this pull request as ready for review September 29, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant