Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADOP-2547 Check all Payments for Successful Fix | WIP #1591

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

hfilmore
Copy link
Contributor

@hfilmore hfilmore commented Oct 16, 2024

Change description

Code previously marked payment as "error" where synchronous API call to check payment status failed. This change rechecks all payments (in reverse order) until a successful payment is found.

A couple of functions have been renamed to more accurately describe what they do.

Breaking change: preview is pointed to a backend preview environment which needs to be changed before merging.

JIRA link

https://tools.hmcts.net/jira/browse/ADOP-2547

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [] No

qasimnawaz-moj
qasimnawaz-moj previously approved these changes Oct 24, 2024
Copy link

@qasimnawaz-moj qasimnawaz-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants