WORK IN PROGRESS Create test coverage for e2e User journey #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abigailsmith97
requested changes
Sep 18, 2024
| page = await context.newPage(); | ||
| await page.goto(urlConfig.citizenStartUrl); | ||
| }); | ||
| test('Start up jourey url is equal to the initial url', async () => { |
There was a problem hiding this comment.
this test might be not needed as it could be incorporated into the other tests and reduce number of tests being run
|
|
||
| expect(htmlLang).toBe('en'); | ||
| }); | ||
| test('Start up journey page is to have Cymraeg language link to be visible', async () => { |
There was a problem hiding this comment.
these two tests could maybe be merged into one test as they look like they are doing quite similar things?
|
|
||
| const htmlLang = await page.evaluate(() => document.documentElement.lang); | ||
|
|
||
| expect(htmlLang).toBe('cy'); |
There was a problem hiding this comment.
might be worth checking if you continue on the user journey, the language remains welsh and does not change back to english
hmcts-jenkins-a-to-c
bot
added
ns:adoption
prd:adoption
rel:adoption-web-pr-1579
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
WORK IN PROGRESS - Created sample test coverage for e2e user journey automated testing which is to be code reviewed
JIRA link
N/A
Does this PR introduce a breaking change? (check one with "x")