Simple left-anchored patterns load and match faster #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid building and compiling a regex for simple patterns (those that don't contain a *, ?, or / character), and instead do a relatively simple string prefix match.
Results on a relatively large CODEOWNERS file that mostly contains simple rules:
A profile suggests that the speedup there is so dramatic mostly because we're compiling fewer regexp objects, which happens once at parse time.
However, a quick test of running this branch against a repository with a large number of files and rules indicates that the matching speed is also improved: