Skip to content

Conversation

hlcfan
Copy link
Owner

@hlcfan hlcfan commented Mar 28, 2021

Very hacky change from integer keys to uuid.

  • SQL to change schema
    • Add uuid columns
    • Populate uuid columns
    • Swap id column with uuid column
    • Change primary key
    • Remove uid
    • Add index to new uuid columns
  • Code changes from uid to id

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #301 (f972c3f) into master (4fb7871) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f972c3f differs from pull request most recent head 6e884ad. Consider uploading reports for the commit 6e884ad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.01%     
==========================================
  Files          75       69       -6     
  Lines        2646     2584      -62     
==========================================
- Hits         2636     2574      -62     
  Misses         10       10              
Impacted Files Coverage Δ
app/models/authorization.rb 100.00% <ø> (ø)
app/models/scheme.rb 100.00% <ø> (ø)
app/models/story.rb 100.00% <ø> (ø)
app/models/user_room.rb 100.00% <ø> (ø)
app/presenters/user_presenter.rb 100.00% <ø> (ø)
app/controllers/rooms_controller.rb 100.00% <100.00%> (ø)
app/models/room.rb 100.00% <100.00%> (ø)
app/models/user_story_point.rb 100.00% <100.00%> (ø)
app/repositories/room_repository.rb 100.00% <100.00%> (ø)
spec/controllers/rooms_controller_spec.rb 100.00% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe4b99...6e884ad. Read the comment docs.

@hlcfan hlcfan merged commit b7d320d into master Apr 4, 2021
@hlcfan hlcfan deleted the switch-to-uuid branch April 4, 2021 03:05
@hlcfan hlcfan mentioned this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant