-
Notifications
You must be signed in to change notification settings - Fork 8
3.5.0 #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 946f562.
* added DkCoreDocumentReference * Update aliases.fsh * Alternative DocRef approach (#158) * Alternative DocRef approach * Further danish constraints * Removed unused alias * update scripts * Update DkCoreDocumentReference.fsh --------- Co-authored-by: Ole Vilstrup <ovi@medcom.dk>
150 profiling of encounter
Added context.sourcePatientInfo only Reference(DkCorePatient)
outcommented context.sourcePatientInfo only Reference(DkCorePatient)
Created short intro page for DocumentReference
Explicit display values for IEEEx73 codes no longer needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR represents the 3.5.0 release of the DK Core FHIR implementation guide, introducing significant enhancements including new profiles for encounters and document references, expanded terminology support, and improved alignment with international standards.
Key Changes:
- Added comprehensive Encounter profile with Danish-specific extensions for planned dates and care provider
- Introduced MinimalDocumentReference profile based on IHE MHD for document sharing in Danish XDS context
- Corrected NPU terminology URL from OID to canonical URL (http://npu-terminology.org)
- Expanded practitioner qualifications to support multiple official health authorizations (0..1 → 0..*)
- Added new value sets for encounter priorities and practice setting codes
- Enhanced documentation with detailed implementation guidance for encounters and document references
- Updated build scripts to include new _build.sh and _build.bat utilities
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| sushi-config.yaml | Updated special-url format to YAML array, added dependencies (hl7.fhir.extensions.r5, ihe.iti.mhd), included NPU URL |
| input/pagecontent/index.md | Added link to standards catalogue, corrected Danish prefix notation to [DA], added IPA compliance details (contains spelling errors) |
| input/pagecontent/StructureDefinition-dk-core-minimaldocumentreference-intro.md | New documentation explaining IHE MHD-based DocumentReference profile and its conformance approach (contains spelling errors) |
| input/pagecontent/StructureDefinition-dk-core-encounter-intro.md | New documentation detailing encounter usage, diagnosis coding, priorities, and R5 compatibility (contains spelling errors) |
| input/fsh/valueSets.fsh | Removed display strings from IEEE codes, added encounter priority and practice setting value sets, simplified SNOMED version reference |
| input/fsh/extensions.fsh | Added three new extensions: PlannedStartDate, PlannedEndDate, and CareProvider for encounters (contains spelling error) |
| input/fsh/codeSystems.fsh | Updated NPU code system metadata with correct URL, OID identifier, contact information, and license |
| input/fsh/aliases.fsh | Corrected NPU alias to use canonical URL, added new aliases for v3-ActPriority, XDS OIDs, and IANA OIDs |
| input/fsh/IPAProfiles.fsh | Uncommented SNOMED CT expansion parameter for includeDesignations |
| input/fsh/DkDocumentVersionIDExtension.fsh | New extension for DocumentReference version ID (R5 backport) |
| input/fsh/DkCorePractitioner.fsh | Changed qualification cardinality to allow multiple authorizations (0..1 → 0..*), updated example |
| input/fsh/DkCoreOrganization.fsh | Added two new example instances for hospital department and sub-department |
| input/fsh/DkCoreMinimalDocumentReference.fsh | New profile and two example instances for APD-DK and PLR-DK document references |
| input/fsh/DkCoreEncounter.fsh | New profile and two example instances demonstrating encounter usage |
| input/fsh/DkCoreBasicParameter.fsh | Fixed constraint from valueQuantity.system to valueQuantity.code |
| _updatePublisher.sh | Added download logic for new _build.sh and _build.bat scripts |
| _updatePublisher.bat | Increased ping timeout, added publisher location display, added _build script downloads |
| _build.sh | New comprehensive build script with menu-driven interface for building IGs |
| _build.bat | New comprehensive build script for Windows with menu-driven interface for building IGs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
input/pagecontent/StructureDefinition-dk-core-minimaldocumentreference-intro.md
Outdated
Show resolved
Hide resolved
input/pagecontent/StructureDefinition-dk-core-minimaldocumentreference-intro.md
Outdated
Show resolved
Hide resolved
input/fsh/DkCorePractitioner.fsh
Outdated
| * ^slicing.discriminator.path = "identifier.system" | ||
| * ^slicing.rules = #open | ||
| * ^slicing.ordered = false | ||
| * ^slicing.description = "Slice based on the identifier.systemm value which allows for official qualifications to\nDeclaring the slices, and their cardinalities, to allow a KL-code and a SNOMED CT code" |
Copilot
AI
Nov 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cardinality of the officialHealthAuthorization slice has been changed from 0..1 to 0..*, allowing practitioners to have multiple official health authorizations. This is a breaking change that increases flexibility but could impact validation of existing data. The updated example correctly demonstrates this by showing a practitioner with two qualifications. Ensure that all consumers of this profile are prepared to handle multiple authorizations.
| * ^slicing.description = "Slice based on the identifier.systemm value which allows for official qualifications to\nDeclaring the slices, and their cardinalities, to allow a KL-code and a SNOMED CT code" | |
| * ^slicing.description = "Slice based on the identifier.system value. The cardinality of the officialHealthAuthorization slice has been changed from 0..1 to 0..*, allowing practitioners to have multiple official health authorizations. This is a breaking change; ensure all consumers are prepared to handle multiple authorizations." | |
| // BREAKING CHANGE: The cardinality of officialHealthAuthorization is now 0..*, allowing multiple authorizations per practitioner. Update all consumers accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're okay with that in a core IG. Such constraints can be made downstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkiddo Note that Copilot actually found and fixed a spelling mistake in the change suggestion above that you missed: systemm -> system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eference-intro.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
| * ^contact.telecom[=].value = "labterm@sundhedsdata.dk" | ||
| * ^experimental = false | ||
| * ^caseSensitive = false | ||
| * ^caseSensitive = true |
Copilot
AI
Nov 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caseSensitive property for the NPU CodeSystem is being changed from false to true. This is a breaking change that could affect existing implementations. NPU codes should be validated to ensure they are consistently cased in all existing profiles, examples, and value sets. Please document this breaking change in the release notes.
input/pagecontent/StructureDefinition-dk-core-minimaldocumentreference-intro.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
input/fsh/DkCorePractitioner.fsh
Outdated
| * ^slicing.discriminator.path = "identifier.system" | ||
| * ^slicing.rules = #open | ||
| * ^slicing.ordered = false | ||
| * ^slicing.description = "Slice based on the identifier.systemm value which allows for official qualifications to\nDeclaring the slices, and their cardinalities, to allow a KL-code and a SNOMED CT code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkiddo Note that Copilot actually found and fixed a spelling mistake in the change suggestion above that you missed: systemm -> system
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
Clarify the role of the implementation guide in relation to the FHIR standard and the IPA specification.
No description provided.