Skip to content

Commit

Permalink
Merge branch 'locking-urgent-for-linus' of git://git.kernel.org/pub/s…
Browse files Browse the repository at this point in the history
…cm/linux/kernel/git/tip/tip

Pull locking fixes from Ingo Molnar:
 "Misc fixes: liblockdep fixes and ww_mutex fixes"

* 'locking-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  locking/ww_mutex: Fix spelling mistake "cylic" -> "cyclic"
  locking/lockdep: Delete unnecessary #include
  tools/lib/lockdep: Add dummy task_struct state member
  tools/lib/lockdep: Add empty nmi.h
  tools/lib/lockdep: Update Sasha Levin email to MSFT
  jump_label: Fix typo in warning message
  locking/mutex: Fix mutex debug call and ww_mutex documentation
  • Loading branch information
torvalds committed Sep 15, 2018
2 parents 3a5af36 + 0b405c6 commit ca062f8
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -8316,7 +8316,7 @@ F: include/linux/libata.h
F: Documentation/devicetree/bindings/ata/

LIBLOCKDEP
M: Sasha Levin <alexander.levin@verizon.com>
M: Sasha Levin <alexander.levin@microsoft.com>
S: Maintained
F: tools/lib/lockdep/

Expand Down
2 changes: 1 addition & 1 deletion kernel/jump_label.c
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ jump_label_module_notify(struct notifier_block *self, unsigned long val,
case MODULE_STATE_COMING:
ret = jump_label_add_module(mod);
if (ret) {
WARN(1, "Failed to allocatote memory: jump_label may not work properly.\n");
WARN(1, "Failed to allocate memory: jump_label may not work properly.\n");
jump_label_del_module(mod);
}
break;
Expand Down
1 change: 0 additions & 1 deletion kernel/locking/lockdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@

#include "lockdep_internals.h"

#include <trace/events/preemptirq.h>
#define CREATE_TRACE_POINTS
#include <trace/events/lock.h>

Expand Down
3 changes: 1 addition & 2 deletions kernel/locking/mutex.c
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ static bool __ww_mutex_wound(struct mutex *lock,
/*
* wake_up_process() paired with set_current_state()
* inserts sufficient barriers to make sure @owner either sees
* it's wounded in __ww_mutex_lock_check_stamp() or has a
* it's wounded in __ww_mutex_check_kill() or has a
* wakeup pending to re-read the wounded state.
*/
if (owner != current)
Expand Down Expand Up @@ -946,7 +946,6 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass,
}

debug_mutex_lock_common(lock, &waiter);
debug_mutex_add_waiter(lock, &waiter, current);

lock_contended(&lock->dep_map, ip);

Expand Down
2 changes: 1 addition & 1 deletion kernel/locking/test-ww_mutex.c
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ static int __test_cycle(unsigned int nthreads)
if (!cycle->result)
continue;

pr_err("cylic deadlock not resolved, ret[%d/%d] = %d\n",
pr_err("cyclic deadlock not resolved, ret[%d/%d] = %d\n",
n, nthreads, cycle->result);
ret = -EINVAL;
break;
Expand Down
3 changes: 3 additions & 0 deletions tools/include/linux/lockdep.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,12 @@ struct task_struct {
struct held_lock held_locks[MAX_LOCK_DEPTH];
gfp_t lockdep_reclaim_gfp;
int pid;
int state;
char comm[17];
};

#define TASK_RUNNING 0

extern struct task_struct *__curr(void);

#define current (__curr())
Expand Down
Empty file added tools/include/linux/nmi.h
Empty file.

0 comments on commit ca062f8

Please sign in to comment.