This repository was archived by the owner on Oct 3, 2020. It is now read-only.
Read default namespace from service account #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikolaev
force-pushed
the
read-default-namespace-from-service-account
branch
from
5554752 to
2d42c52
Compare
|
This would change the behavior for deployments in non-default namespace and be a breaking change, right? |
|
Yes, that's true. Do you think that would be a big issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads default namespace which have to be used for all namespaced operations from
/var/run/secrets/kubernetes.io/serviceaccount/namespaceand configures context with it.