This repository was archived by the owner on Oct 3, 2020. It is now read-only.
support ExecCredential authentication #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you also describe the support in the docs (https://pykube.readthedocs.io/)? (the docs are not very extensive right now, but could see some love..) |
|
Found an error while testing the code with our use of |
|
@dash1291 this is still marked as "wip", do you want to complete the PR? |
|
@hjacobs @dlmiddlecote sorry guys, I've got busy lately and missed this. I'll get to it asap and make it merge ready. |
Co-Authored-By: Daniel Middlecote <dlmiddlecote@gmail.com>
dash1291
force-pushed
the
feature-add-exec-method
branch
from
787ab04 to
889325c
Compare
dash1291
changed the title
|
@hjacobs @dlmiddlecote @zoidbergwill addressed all comments. let me know if it's good to merge |
hjacobs
reviewed
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This by no means is a final change, but through this I was able to make pykube work for our team where we use
aws-iam-authenticatorto authenticate users on our k8s clusters.Let me know if this is already in the works somewhere. In case it's not and it seems to be a good addition to this project, then I'd love to make this ready for code review and hopefully merge.
Looking forward to inputs.