-
Notifications
You must be signed in to change notification settings - Fork 14
Translated documentation #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also is a test on how updates work
daniel-illi
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The translations were in the wrong locations, leading to overhead in transifex and a simply not-working setup for readthedocs.
I added a Rakefile that takes care of updating the translations, both the sources and the translations.
After changes in the source (both changed files and new files), transifex needs updated sources. This extraction and is handled by
rake sources:update
.According to the docs and local tests, the translations need to be in
locales/<lang>/LC_MESSAGES/*
. Theses need to be committed and pushed so that readthedocs can build the multi-language website. This is handled byrake translations:update
. The updated code is not pushed to GitHub. This is slightly inconsistent, but agit push
feels more harmful thantx push --source
. I am open to be convinced otherwise, though.Fixes hitobito/hitobito#1894