feat: code coverage with playwright #90
Conversation
feat: add test cases for health check and todo app
… feat/coverage
… feat/coverage
feat: added test cases for seeds
… feat/coverage
|
@jwala-anirudh There are some conflicts in this branch. Please resolve whenever you are free. Thanks! :-D |
There was a problem hiding this comment.
@jwala-anirudh Thanks for the PR! PR looks good apart from some minor changes to be done. Also, can we add steps to test our app in README.md similar to installation instructions? That would be great.
| ### Folder Structure: | ||
|
|
||
| ``` | ||
| $ROOT_FOLDER/e2e/{package}/{module}/{file-indicator}.test.js |
There was a problem hiding this comment.
We can add folders that are standardise by default with .gitkeep included, giving user freedom to only create {file-indicator}.test.js and nothing else.
You can refer to our frontend example folder for this (I understand that we have some preconfigured test files in e2e folder but we can predefined nested folders based on packages and modules) and we can create predefined folders for each package and module with .gitkeep file in it to avoid inconsistent packages and modules being injected by contributors.
Would love to hear from you about this approach @jwala-anirudh
There was a problem hiding this comment.
Only reason behind this was to keep the e2e folder structure same as src as close as possible in order to understand to which file exactly the test case is being added to.
There was a problem hiding this comment.
@jwala-anirudh Thanks for the clarification. We will review the folder structure thoroughly to keep our e2e tests consistent before merging.
Addressing our long standing issue #43 we add the following changes.
todos,healthcheckContributor: @shrey-dadhaniya