Skip to content

chore: adding some missed return types #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

chore: adding some missed return types #209

merged 1 commit into from
Dec 13, 2023

Conversation

@mjsafarali
Copy link

@mjsafarali mjsafarali commented Nov 17, 2023

  • Some missed returned types added.

@coveralls
Copy link

coveralls commented Dec 7, 2023

Coverage Status

coverage: 98.142%. remained the same
when pulling f88d4f1 on mjsafarali:chore/adding-return-type
into 935a1f2 on hisorange:stable.

@mjsafarali
Copy link
Author

mjsafarali commented Dec 9, 2023

thanks for your mention, it's not going to increase test coverage. It is for a better code style.

@hisorange hisorange merged commit dafa208 into hisorange:stable Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjsafarali @coveralls @hisorange