Implemented Modbus Function code FC23 client function. #38

Okoyl · 2023-12-19T11:10:40Z

I have implemented FC23 support, it allows writing and reading multiple registers on a single transmission.

hirschenberger

Hello, thank you for that PR. Can you also please add WriteReadMultiple tests to tests/lib.rs and check them with:

cargo test --features modbus-server-tests

src/tcp.rs

Okoyl · 2023-12-19T19:24:21Z

Hello, thank you for that PR. Can you also please add WriteReadMultiple tests to tests/lib.rs and check them with:
cargo test --features modbus-server-tests

I added a simple test that checks it twice, it passes the test.

src/tcp.rs

Implemented Modbus Function code FC23 client function.

f3f4914

hirschenberger reviewed Dec 19, 2023

View reviewed changes

src/tcp.rs Outdated Show resolved Hide resolved

Simplified write_read_multiple code, added a simple test for it.

e3a8e63

hirschenberger reviewed Dec 20, 2023

View reviewed changes

src/tcp.rs Outdated Show resolved Hide resolved

Removed return statement.

ca2ca0a

hirschenberger merged commit d259a8a into hirschenberger:master Dec 20, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented Modbus Function code FC23 client function. #38

Implemented Modbus Function code FC23 client function. #38

Okoyl commented Dec 19, 2023

hirschenberger left a comment

Okoyl commented Dec 19, 2023

Implemented Modbus Function code FC23 client function. #38

Implemented Modbus Function code FC23 client function. #38

Conversation

Okoyl commented Dec 19, 2023

hirschenberger left a comment

Choose a reason for hiding this comment

Okoyl commented Dec 19, 2023