feat: add replaced_by_tx_id to replaced mempool transactions #2271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://stacks-blockchain-1ht0fcc46-hirosystems.vercel.app 🚀 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
rafaelcr
changed the title
rafaelcr
commented
May 21, 2025
|
|
||
| test('prunes transactions with nonces that were already confirmed', async () => { | ||
| // Initial block | ||
| test('prunes and restores replaced-by-fee transactions', async () => { |
Collaborator
Author
There was a problem hiding this comment.
@zone117x this is the main test of the new functionality
zone117x
reviewed
May 22, 2025
Contributor
zone117x
left a comment
zone117x
left a comment
There was a problem hiding this comment.
The code looks great, nice tests 💯
The new sql query is in the block ingestion path -- have we tested its performance?
Collaborator
Author
|
@zone117x thanks, I've tested locally but the next step will be to deploy this PR to dev and then staging to perform some load tests |
zone117x
approved these changes
May 23, 2025
This was referenced Jul 21, 2025
hirosystems-release-bot bot
added a commit
that referenced
this pull request
Aug 6, 2025
## [8.12.0](v8.11.6...v8.12.0) (2025-08-06) ### Features * Add exclude_function_args parameter to reduce transaction response sizes ([#2312](#2312)) ([852a60e](852a60e)) * add replaced_by_tx_id to replaced mempool transactions ([#2271](#2271)) ([a70c3d1](a70c3d1)) * **prometheus:** add chain tip metrics ([#2333](#2333)) ([bde1037](bde1037)) * SNP integration ([#2291](#2291)) ([9a159e1](9a159e1)) ### Bug Fixes * drop redundant db indexes ([#2329](#2329)) ([0ddd6a6](0ddd6a6)) * ensure some ops only run when SNP is not enabled ([fd4717b](fd4717b)) * only ingest snp chain events to avoid db bloat ([287f572](287f572)) * optimize queries to prune and restore mempool rbf txs ([#2327](#2327)) ([0b196f0](0b196f0)) * optimize replace-by-fee mempool calculations ([#2326](#2326)) ([01998bc](01998bc)) * parallelize mempool rbf updates ([#2328](#2328)) ([e7347e5](e7347e5)) * update snp image in tests ([c7c0dbb](c7c0dbb))
Contributor
|
🎉 This PR is included in version 8.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs multiple checks to make sure we trace transactions that are replaced by fee correctly:
replaced_by_tx_idkey to dropped mempool transaction responses that will include another transaction ID if this represents an RBF operation.new_tx_idfield from Stacks core when included on dropped mempool messagesReplaces #2141
Fixes #1813