fix: event-replay block parsing outdated and incorrect #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Vercel deployment URL: https://stacks-blockchain-hvppvv6qd-hirosystems.vercel.app 🚀 |
blockstack-devops
pushed a commit
that referenced
this pull request
Oct 23, 2024
## [8.2.0-beta.1](v8.1.2...v8.2.0-beta.1) (2024-10-23) ### Features * allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef)) * include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2)) * ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154)) ### Bug Fixes * event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa))
|
🎉 This PR is included in version 8.2.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
blockstack-devops
pushed a commit
that referenced
this pull request
Oct 25, 2024
## [8.2.0](v8.1.2...v8.2.0) (2024-10-25) ### Features * allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef)) * include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2)) * ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154)) ### Bug Fixes * event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa))
|
🎉 This PR is included in version 8.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event-replay logic was using a copy&pasted function for parsing
/new_blockdata, which had become outdated and incorrect.This removes the duplicated code, and both event-replay and regular block ingestion use the same (correct) block parsing code.