[Client] Critical dependency error

[kyranjamie]

Describe the bug

Browser bundle emits the following error, when importing and using the client

../stacks-blockchain-api/client/node_modules/jsonrpc-lite/jsonrpc.js 16:24-31
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

See this PR, which references the same issue: teambition/jsonrpc-lite#17

Supposedly it's fixed in that PR, but hasn't been spoken of in 12 months.

[zone117x]

We may need to fork, merge that PR and publish an updated package. Or inline the code we use from it.

[zensh]

https://github.com/teambition/jsonrpc-lite/blob/master/jsonrpc.js#L16
the jsonrpc.js is generated by tsc with optionmodule=UMD, and require function do not need by jsonrpc.

could you close the warning message in webpack?

[kyranjamie]

@zensh I tried setting the stats property to none and errors-only, but that doesn't remove the error.

Can the issue be fixed in the jsonrpc package by bundling it differently, or perhaps merging the PR with the fix?

[zensh]

@kyranjamie change the code https://github.com/teambition/jsonrpc-lite/blob/master/jsonrpc.js#L16 to

var v = factory(null, exports);

will work?

[zone117x]

@zensh The library should be bundled in a more friendly way. UMD format for package.js main field is problematic. Typically libraries should use a cjs file output for main, and use a esm file output for the module field. UMD is useful for CDNs like unpkg which have their own package.json field.

Something like a package.json with:

{
  "main": "dist/lib.cjs.js",
  "module": "dist/lib.esm.js",
  "unpkg": "dist/lib.umd.js",
}

Would it be helpful if I made a PR for this? It shouldn't require as many changes as the existing PR.

[zensh]

v2.2.0 released, https://github.com/teambition/jsonrpc-lite/blob/master/package.json#L8

[blockstack-devops]

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀