-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add disable_postgres flag and separate from stack_api disabling #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippenein
changed the title
add disable_postgres flag and separate from stack_api disabling
chore: add disable_postgres flag and separate from stack_api disabling
Sep 14, 2024
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
tippenein
force-pushed
the
chore/separate-postgres-from-stacks-api
branch
2 times, most recently
from
September 23, 2024 03:32
2077c20
to
5f59d3f
Compare
hugocaillard
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TUI changes
tippenein
force-pushed
the
chore/separate-postgres-from-stacks-api
branch
from
September 23, 2024 13:25
5f59d3f
to
e7d2247
Compare
tippenein
force-pushed
the
chore/separate-postgres-from-stacks-api
branch
from
September 23, 2024 16:03
fcc3e76
to
3764feb
Compare
hugocaillard
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use clarinet's devnet for testing the api functionality we needed a way of disabling one or the other
disable_postgres
field in Devnet.toml is essentially the main addition here, but also implies thatdisable_stacks_api
no longer disables postgres which it did do previously