Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add disable_postgres flag and separate from stack_api disabling #1558

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

tippenein
Copy link
Collaborator

In order to use clarinet's devnet for testing the api functionality we needed a way of disabling one or the other

disable_postgres field in Devnet.toml is essentially the main addition here, but also implies that disable_stacks_api no longer disables postgres which it did do previously

@tippenein tippenein changed the title add disable_postgres flag and separate from stack_api disabling chore: add disable_postgres flag and separate from stack_api disabling Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/stacks-network/src/orchestrator.rs 0.00% 34 Missing ⚠️
components/clarinet-files/src/network_manifest.rs 0.00% 4 Missing ⚠️
components/clarinet-cli/src/generate/project.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tippenein tippenein force-pushed the chore/separate-postgres-from-stacks-api branch 2 times, most recently from 2077c20 to 5f59d3f Compare September 23, 2024 03:32
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TUI changes

components/stacks-network/src/orchestrator.rs Outdated Show resolved Hide resolved
components/stacks-network/src/orchestrator.rs Outdated Show resolved Hide resolved
@tippenein tippenein force-pushed the chore/separate-postgres-from-stacks-api branch from 5f59d3f to e7d2247 Compare September 23, 2024 13:25
@tippenein tippenein force-pushed the chore/separate-postgres-from-stacks-api branch from fcc3e76 to 3764feb Compare September 23, 2024 16:03
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@tippenein tippenein merged commit 1bdc272 into main Sep 24, 2024
19 checks passed
@tippenein tippenein deleted the chore/separate-postgres-from-stacks-api branch September 24, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants