Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update clarity and support clarity 3 #1484

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Jun 25, 2024

Description

  • Handle Clarity 3 functions
    • get-tenure-info?
    • get-stacks-block-info?
  • Support HeadersDB trait changes
  • Better tests

Fixes: #1468

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 92.49395% with 31 lines in your changes missing coverage. Please review.

Project coverage is 41.34%. Comparing base (a80e4b5) to head (d52a7a3).

Files Patch % Lines
components/clarity-repl/src/repl/datastore.rs 47.27% 29 Missing ⚠️
components/clarity-repl/src/repl/interpreter.rs 99.58% 1 Missing ⚠️
components/clarity-repl/src/repl/session.rs 98.52% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   40.86%   41.34%   +0.48%     
==========================================
  Files          87       87              
  Lines       32368    32617     +249     
==========================================
+ Hits        13226    13485     +259     
+ Misses      19142    19132      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard
Copy link
Collaborator Author

Requested review from @obycode and @MicaiahReid

@obycode - can you especially double check the datastore changes?

Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@hugocaillard hugocaillard merged commit 3365470 into main Jun 27, 2024
19 checks passed
@hugocaillard hugocaillard deleted the feat/update-clarity branch June 27, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Handle Clarity 3
3 participants