Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/handle clarity 3 #1465

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Feat/handle clarity 3 #1465

merged 7 commits into from
Jun 7, 2024

Conversation

hugocaillard
Copy link
Collaborator

Description

Update clarity-vm and clar2wasm.

Handle clarity 3 keywords as well as the new max_version property in the clarity reference.
Tried to make it clearer when a keyword/function was introduced and removed


Before:
Screenshot 2024-06-03 at 17 53 46

After:
Screenshot 2024-06-03 at 17 50 47

With error (previously, it wouldn't even show the documentation)
Screenshot 2024-06-03 at 17 55 13

@hugocaillard hugocaillard marked this pull request as draft June 3, 2024 16:31
@hugocaillard hugocaillard self-assigned this Jun 3, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 39.83740% with 74 lines in your changes missing coverage. Please review.

Project coverage is 40.73%. Comparing base (343a01a) to head (56204ee).

Files Patch % Lines
components/clarinet-deployments/src/types.rs 0.00% 23 Missing ⚠️
components/clarinet-files/src/project_manifest.rs 67.85% 18 Missing ⚠️
...ents/clarity-lsp/src/common/requests/completion.rs 0.00% 16 Missing ⚠️
components/clarity-repl/src/repl/datastore.rs 0.00% 6 Missing ⚠️
...omponents/clarity-lsp/src/common/requests/hover.rs 0.00% 3 Missing ⚠️
...ponents/clarity-lsp/src/common/requests/api_ref.rs 83.33% 2 Missing ⚠️
components/clarity-lsp/src/common/state.rs 0.00% 2 Missing ⚠️
components/stacks-codec/src/codec.rs 0.00% 2 Missing ⚠️
...omponents/clarinet-deployments/src/requirements.rs 0.00% 1 Missing ⚠️
components/clarity-repl/src/repl/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   40.71%   40.73%   +0.02%     
==========================================
  Files          87       87              
  Lines       32412    32370      -42     
==========================================
- Hits        13197    13187      -10     
+ Misses      19215    19183      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard hugocaillard marked this pull request as ready for review June 7, 2024 14:29
@hugocaillard hugocaillard enabled auto-merge (squash) June 7, 2024 14:29
@hugocaillard hugocaillard merged commit 2c92bef into main Jun 7, 2024
17 checks passed
@hugocaillard hugocaillard deleted the feat/handle-clarity-3 branch June 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant