-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: call private function in simnet #1380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocaillard
force-pushed
the
feat/call-private-function-in-sdk
branch
from
March 12, 2024 18:21
06ad555
to
7b195bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
==========================================
+ Coverage 41.38% 41.80% +0.42%
==========================================
Files 87 88 +1
Lines 31993 32405 +412
==========================================
+ Hits 13241 13548 +307
- Misses 18752 18857 +105 ☔ View full report in Codecov by Sentry. |
MicaiahReid
reviewed
Mar 13, 2024
MicaiahReid
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #547
Description
Allow to contract private functions from the simnet.
It requires the changes of this PR stacks-network/stacks-core#4520, which have been cherry-picked on feat/clarity-wasm-next.
call_contract_fn
In the interpreter, there's a new
call_contract_fn
method that can be used instead ofrun
orexecute
to perform contract calls.This method is slightly more performant (it doesn't build an virtual contract and has a better clarity args serialization logic).
This improved way to all contract functions is now used for
callPublicFn
andcallReadOnlyFn
as wellChecklist