-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/handle deployment plans in simnet #1360
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1360 +/- ##
===========================================
+ Coverage 41.17% 41.43% +0.25%
===========================================
Files 86 87 +1
Lines 31643 31813 +170
===========================================
+ Hits 13030 13181 +151
- Misses 18613 18632 +19 ☔ View full report in Codecov by Sentry. |
038a88d
to
18fdc27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question and one tiny code change, but nothing blocking. Great work!
Description
ContractPublish
orEmulatedContractPublish
, but the manifest has changed, we generate the new deployment plan and re-apply the custom txs. Instead of prompting the user to ask to if they want to overwrite the changesSome refactor
clarinet-deployments
crates. So that we don't serde-yaml in other cratesIdeas