Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/handle deployment plans in simnet #1360

Merged
merged 10 commits into from
Mar 1, 2024

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Feb 23, 2024

Description

  • Handle deployment plans in clarinet-sdk (simnet)
  • If the deployment plan has been customized with txs other than ContractPublish or EmulatedContractPublish, but the manifest has changed, we generate the new deployment plan and re-apply the custom txs. Instead of prompting the user to ask to if they want to overwrite the changes

Some refactor

  • I try to isolate the serialization/de-serialization of the deployment-plan in the clarinet-deployments crates. So that we don't serde-yaml in other crates
  • Feature flag some methods that are only used in the cli

Ideas

  • In future version we want to extend the feature to clarinet console
  • We also need to validate this way of re-apply custom txs and use it for devnet deployment plan handling

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 70.47619% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 41.43%. Comparing base (a6d4504) to head (aaca439).

Files Patch % Lines
components/clarinet-cli/src/frontend/cli.rs 0.00% 30 Missing ⚠️
components/clarinet-deployments/src/types.rs 62.16% 28 Missing ⚠️
components/clarinet-cli/src/deployments/types.rs 0.00% 2 Missing ⚠️
components/clarinet-cli/src/deployments/mod.rs 0.00% 1 Missing ⚠️
components/clarinet-deployments/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1360      +/-   ##
===========================================
+ Coverage    41.17%   41.43%   +0.25%     
===========================================
  Files           86       87       +1     
  Lines        31643    31813     +170     
===========================================
+ Hits         13030    13181     +151     
- Misses       18613    18632      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard hugocaillard force-pushed the feat/handle-deployment-plans-in-simnet branch from 038a88d to 18fdc27 Compare February 27, 2024 18:37
@hugocaillard hugocaillard marked this pull request as ready for review February 28, 2024 23:47
Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question and one tiny code change, but nothing blocking. Great work!

components/clarinet-sdk-wasm/src/core.rs Show resolved Hide resolved
components/clarinet-sdk/tests/simnet-usage.test.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants