Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove errors on exit when running devnet with --no-dashboard #1357

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Feb 20, 2024

Fixes #1309.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (abc3458) 41.19% compared to head (85f3ea8) 41.20%.

Files Patch % Lines
components/stacks-network/src/lib.rs 0.00% 14 Missing ⚠️
components/clarinet-cli/src/frontend/cli.rs 0.00% 8 Missing ⚠️
...omponents/stacks-network/src/chains_coordinator.rs 0.00% 5 Missing ⚠️
components/clarinet-cli/src/devnet/start.rs 0.00% 1 Missing ⚠️
components/stacks-network/src/ui/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1357   +/-   ##
========================================
  Coverage    41.19%   41.20%           
========================================
  Files           86       86           
  Lines        31625    31631    +6     
========================================
+ Hits         13029    13033    +4     
- Misses       18596    18598    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hugocaillard hugocaillard merged commit fad5c76 into develop Feb 26, 2024
19 checks passed
@hugocaillard hugocaillard deleted the fix-no-dashboard branch February 26, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unexpected error using --no-dashboard flag
2 participants