Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/devnet pox and stacking #1350

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

hugocaillard
Copy link
Collaborator

Description

Add a few fixes and improvement to be released as 2.2.1

  • The publish_stacking_order formula wasn't working on some edge case

    • duration = 1
    • start_at_cycle > duration
      The new formula is slightly simpler (still a bit complicated but well..) and it works in all cases
  • Handle the reward_cycle_length property in PoxInfo and revert the regression on reward_phase_block_length

    • This fix requires the update on chainhook
  • In the devnet UI, avoid multiple > in case a nakamoto block is mined at the same block height as the beginning of a new pox cycle (eg – [12]> – [11]> – <[10] –)

  • use a fixed tag for the hirosystems/stacks-blockchain-api docker image (because :nakamoto is updated frequently)

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugocaillard hugocaillard merged commit bc74e5a into develop Feb 8, 2024
19 checks passed
@hugocaillard hugocaillard deleted the fix/devnet-pox-and-stacking branch February 8, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants