Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run clarity-wasm in a separate session #1330

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

hugocaillard
Copy link
Collaborator

Description

Revamp the way we run the clarity-wasm preview in clarinet console . We now run two session in parallel, the second one run in "wasm-mode".

  • The second session (the wasm one), can be disabled with:
clarinet console --disable-clarity-wasm
  • If the interpreter and clarity-wasm return different results, the results are logged and a message asks the users to open an issue
Screenshot 2024-01-24 at 20 58 11
  • These PR also implements a ::toggle_timings that give an approximate idea of how long a snippet execution took

@hugocaillard hugocaillard removed the request for review from obycode January 24, 2024 20:05
@hugocaillard hugocaillard changed the title feat: run clarity-wasm in a serate session feat: run clarity-wasm in a separate session Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 158 lines in your changes are missing coverage. Please review.

Comparison is base (dd51ea9) 41.79% compared to head (789a856) 40.28%.

Files Patch % Lines
components/clarity-repl/src/frontend/terminal.rs 0.00% 59 Missing ⚠️
components/clarity-repl/src/repl/interpreter.rs 27.58% 42 Missing ⚠️
components/clarinet-cli/src/frontend/cli.rs 0.00% 36 Missing ⚠️
components/clarity-repl/src/repl/session.rs 60.41% 19 Missing ⚠️
components/clarity-repl/src/bin.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1330      +/-   ##
===========================================
- Coverage    41.79%   40.28%   -1.52%     
===========================================
  Files           87       87              
  Lines        32028    31591     -437     
===========================================
- Hits         13387    12727     -660     
- Misses       18641    18864     +223     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugocaillard hugocaillard enabled auto-merge (squash) January 25, 2024 09:22
@hugocaillard hugocaillard merged commit fdf400b into develop Jan 25, 2024
19 checks passed
@hugocaillard hugocaillard deleted the feat/clarity-wasm-improvement branch January 25, 2024 09:23
This was linked to issues Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve clarity-wasm behaviour in console Handle clarity-wasm
2 participants