-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove chainhook subcommands #1328
chore: remove chainhook subcommands #1328
Conversation
@tippenein: 💥! |
6bca7b7
to
7adee9a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1328 +/- ##
===========================================
+ Coverage 40.44% 40.64% +0.20%
===========================================
Files 87 86 -1
Lines 31766 31591 -175
===========================================
- Hits 12847 12841 -6
+ Misses 18919 18750 -169 ☔ View full report in Codecov by Sentry. |
Thanks @tippenein. And happy new year! 🎉 What do you think about printing a message explaining that No hurry on this, I think we'll hold the PR for after the next release (2.2.0) |
hey @hugocaillard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tippenein, thanks for the PR!
I had some time to give this one some thought, and I think we only actually want part of this change.
Clarinet had the clarinet chainhook new
command that would generate chainhooks that are no longer compatible with the actual Chainhook tool. Now that Chainhook is a standalone tool, we don't need to have the generation of these files inside of Clarinet.
However, Clarinet still finds a user's chainhooks in their working directory and automatically registers them with their devnet, which is a really helpful feature that we actually just released a guide on.
Would you be able to revert the changes that remove chainhook from the devnet?
@MicaiahReid thanks for the feedback. So, we're essentially only deprecating the |
@tippenein Apologies for the mixed messaging here. We can also deprecate What will need to remain is all code that is used by the |
72181b6
to
bea312a
Compare
@MicaiahReid Yea that makes total sense. It should be good now 👍 lmk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @tippenein!
Thanks @tippenein! |
closes #1308
(also fixes #1310 links)