feature: add getBlockTime() to simnet #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippenein
commented
Dec 5, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1273 +/- ##
===========================================
+ Coverage 41.79% 41.85% +0.05%
===========================================
Files 87 87
Lines 31353 31369 +16
===========================================
+ Hits 13105 13128 +23
+ Misses 18248 18241 -7 ☔ View full report in Codecov by Sentry. |
hugocaillard
force-pushed
the
simnet-getBlockTime-1269
branch
from
1b06658
to
9646152
Compare
hugocaillard
force-pushed
the
simnet-getBlockTime-1269
branch
from
9646152
to
2d395e8
Compare
|
Hey @tippenein |
tippenein
force-pushed
the
simnet-getBlockTime-1269
branch
from
184a78d
to
24d2779
Compare
|
@hugocaillard haven't looked since last week but I never succeeded in getting the link to work. I can take a closer look later today |
hugocaillard
requested changes
Dec 12, 2023
tippenein
force-pushed
the
simnet-getBlockTime-1269
branch
from
afe09e7
to
6a941c8
Compare
hugocaillard
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
LGTM 👏
Thanks a lot @tippenein and thanks for helping me improving the contribution doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1269