-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ugprade clap #1263
chore: ugprade clap #1263
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1263 +/- ##
===========================================
+ Coverage 40.06% 40.15% +0.08%
===========================================
Files 86 86
Lines 30844 30848 +4
===========================================
+ Hits 12358 12387 +29
+ Misses 18486 18461 -25 ☔ View full report in Codecov by Sentry. |
I couldn't control, but 👏🏽 👏🏽. |
5d749f5
to
a83331a
Compare
a83331a
to
65c564f
Compare
Hey @tippenein, pinging you so that you can see the few changes implied by the new clap version |
65c564f
to
53d484b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that refactoring was really need! Code LGTM. Just a small typo to fix.
Co-authored-by: Chris Guimarães <cguimaraes@hiro.so>
Description
In an effort to keep the project dependencies updated, upgrade clap to the latest version.
clap_generate
has been renamed toclap_complete
conflicts_with
now takes the actual property name (not thelong
form)I removed the deprecated
Test
andRun
commands, it's a bit early bit I'm quite in a quest to remove as much dead code as I can on the repo