Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ugprade clap #1263

Merged
merged 2 commits into from
Nov 24, 2023
Merged

chore: ugprade clap #1263

merged 2 commits into from
Nov 24, 2023

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Nov 22, 2023

Description

In an effort to keep the project dependencies updated, upgrade clap to the latest version.

  • clap_generate has been renamed to clap_complete
  • conflicts_with now takes the actual property name (not the long form)
  • re-arranged a bit the enums and macros (for aliases)
  • make everything slightly more consistent

I removed the deprecated Test and Run commands, it's a bit early bit I'm quite in a quest to remove as much dead code as I can on the repo

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (3b75bbc) 40.06% compared to head (53d484b) 40.15%.

❗ Current head 53d484b differs from pull request most recent head e621b9b. Consider uploading reports for the commit e621b9b to get more accurate results

Files Patch % Lines
components/clarinet-cli/src/frontend/cli.rs 47.36% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1263      +/-   ##
===========================================
+ Coverage    40.06%   40.15%   +0.08%     
===========================================
  Files           86       86              
  Lines        30844    30848       +4     
===========================================
+ Hits         12358    12387      +29     
+ Misses       18486    18461      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sabbyanandan
Copy link
Contributor

chore: ugprade clap

I couldn't control, but 👏🏽 👏🏽.

@hugocaillard
Copy link
Collaborator Author

Hey @tippenein, pinging you so that you can see the few changes implied by the new clap version

csgui
csgui previously approved these changes Nov 24, 2023
Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that refactoring was really need! Code LGTM. Just a small typo to fix.

components/clarinet-cli/src/frontend/cli.rs Outdated Show resolved Hide resolved
Co-authored-by: Chris Guimarães <cguimaraes@hiro.so>
@csgui csgui self-requested a review November 24, 2023 10:47
@hugocaillard hugocaillard merged commit ee608aa into develop Nov 24, 2023
18 checks passed
@hugocaillard hugocaillard deleted the chore/upgrade-clap branch November 24, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants