Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add 'clarinet contract rm <name>' #1261

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

tippenein
Copy link
Collaborator

@tippenein tippenein commented Nov 21, 2023

fixes: #686

Screenshot 2023-11-21 at 11 13 26 AM

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (9e9f770) 41.96% compared to head (74444c6) 41.79%.

Files Patch % Lines
components/clarinet-cli/src/generate/contract.rs 0.00% 62 Missing ⚠️
components/clarinet-cli/src/frontend/cli.rs 2.22% 44 Missing ⚠️
components/clarinet-cli/src/generate/mod.rs 0.00% 7 Missing ⚠️
components/clarinet-cli/src/generate/changes.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1261      +/-   ##
===========================================
- Coverage    41.96%   41.79%   -0.17%     
===========================================
  Files           87       87              
  Lines        31238    31353     +115     
===========================================
- Hits         13108    13105       -3     
- Misses       18130    18248     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard
Copy link
Collaborator

Thanks @tippenein
Great addition. Think this actually deletes code, I think it might be safe to prompt for confirmation?

Like

This command will delete the files contract.test.ts contract.clar and remove the contract from the manifest. Do you confirm? [y/N]

What do you think?

@tippenein
Copy link
Collaborator Author

Yeah, prompt is good 👍
Will add

@hugocaillard
Copy link
Collaborator

Hey @tippenein
I'll test and review before end of week

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot @tippenein

@hugocaillard hugocaillard enabled auto-merge (squash) December 6, 2023 11:50
@hugocaillard hugocaillard enabled auto-merge (squash) December 6, 2023 11:51
@hugocaillard hugocaillard merged commit 98f9d4d into hirosystems:develop Dec 6, 2023
19 checks passed
@tippenein tippenein deleted the add-contract-rm-686 branch December 6, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add clarinet contracts rm <contract-name>
2 participants