Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/improve coverage #1246

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Tests/improve coverage #1246

merged 5 commits into from
Nov 28, 2023

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Nov 14, 2023

Description

This PR is an attempt to clean up some dead code and add some unit tests.

  • fix some of the remaining clippy warnings (should be the last)
  • remove the online clarity repls (clarity-repl/docs) - it has been offline for a few months now and outdated since more, it should be reworked with the clarinet-sdk
  • clean some dead code (clarity-utils wasn't imported anywhere)
  • add some unit-tests
    • introducing centralized fixture for clarity-repl, hoping to extend it and use it more in the future
  • refactor, simplify, and test a great chunk of interpreter.rs

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 150 lines in your changes are missing coverage. Please review.

Comparison is base (c78709c) 40.15% compared to head (ae8a1a5) 41.96%.

Files Patch % Lines
components/clarity-events/src/analysis/mod.rs 0.00% 21 Missing ⚠️
components/clarity-repl/src/repl/interpreter.rs 96.77% 21 Missing ⚠️
...clarity-repl/src/test_fixtures/clarity_contract.rs 67.21% 20 Missing ⚠️
components/clarity-repl/src/repl/debug/dap/mod.rs 0.00% 19 Missing ⚠️
components/stacks-devnet-js/src/lib.rs 0.00% 18 Missing ⚠️
components/clarity-repl/src/repl/session.rs 75.47% 13 Missing ⚠️
components/clarity-repl/src/codec/mod.rs 0.00% 11 Missing ⚠️
components/clarity-repl/src/repl/datastore.rs 9.09% 10 Missing ⚠️
components/clarity-repl/src/repl/debug/mod.rs 0.00% 6 Missing ⚠️
components/clarity-repl/src/bin.rs 0.00% 4 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1246      +/-   ##
===========================================
+ Coverage    40.15%   41.96%   +1.80%     
===========================================
  Files           86       87       +1     
  Lines        30848    31236     +388     
===========================================
+ Hits         12387    13108     +721     
+ Misses       18461    18128     -333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard hugocaillard force-pushed the tests/improve-coverage branch 10 times, most recently from fc354e6 to 1d348d8 Compare November 21, 2023 14:45
@hugocaillard hugocaillard force-pushed the tests/improve-coverage branch 3 times, most recently from f63d43d to 7f605a3 Compare November 24, 2023 14:39
@hugocaillard hugocaillard marked this pull request as ready for review November 24, 2023 16:13
Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring and deletion of unused code seems to be ok. Code LGTM.

@hugocaillard hugocaillard merged commit 8dc6780 into develop Nov 28, 2023
19 checks passed
@hugocaillard hugocaillard deleted the tests/improve-coverage branch November 28, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants