Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace . with _ for contract names #1202

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

tippenein
Copy link
Collaborator

Description

fixes #1031 by replacing . with _ in contract file names

Breaking change?

N/A

Example

Screenshot 2023-10-11 at 4 01 54 PM


Checklist

  • Tests added in this PR (if applicable)

If there are applicable tests to add, I'm glad to do that. I was unable to find them tho, so I added the screenshots above

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023

CLA assistant check
All committers have signed the CLA.

@tippenein
Copy link
Collaborator Author

Still looking for documentation on what characters are allowed for clarity file names, but will update if I find anything beyond what was reported in the issue

@tippenein
Copy link
Collaborator Author

Still looking for documentation on what characters are allowed for clarity file names, but will update if I find anything beyond what was reported in the issue

It looks like you can get around the check if you use " but this seems outside of plausible use.

cargo run contracts new char."?"

will create a new contract called char_? but won't be able to run. Seems like anyone doing this would expect trouble though..

@hugocaillard
Copy link
Collaborator

I think it makes sense as it is.

For other unexpected use cases, we probably want to throw an error instead. It can be addressed in a future PR.

Can you sign CLA please?

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for your contribution @tippenein

@hugocaillard hugocaillard merged commit 165bfb9 into hirosystems:develop Oct 12, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

clarinet contracts allows creating contracts with illegal names
3 participants