-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: clarinet cli revamp #1104
ci: clarinet cli revamp #1104
Conversation
ci: disable macos docker image build, it will likely require doing something similar to this https://github.com/stacks-network/stacks-blockchain/blob/master/.github/actions/dockerfiles/Dockerfile.debian-binary
Codecov Report
@@ Coverage Diff @@
## develop #1104 +/- ##
============================================
- Coverage 34.02% 17.78% -16.25%
============================================
Files 180 145 -35
Lines 47486 42650 -4836
============================================
- Hits 16158 7584 -8574
- Misses 31328 35066 +3738
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is awesome, thanks @CharlieC3 🙌 |
@hugocaillard Yup, that's the idea! I'm grabbing the latest version of the clarinet-cli component tag here, then comparing it against the version found in components/clarinet-cli/Cargo.toml here. If there's no match, a new tag will be created in the format of So just like before, to create a new clarinet-cli version, you have to bump this line and commit/merge it to However, we likely won't get good results if we merge this CI workflow in while we keep the original CI workflow active. It's up to you on how you'd like to handle this, but I would suggest disabling the new workflow until you have workflows for all components set up and ready before removing the old CI workflow. |
@hugocaillard Not sure if you saw my comment above. Any thoughts. How would you like to proceed? |
I need to check what was the old CI doing that the new doesn't. |
@hugocaillard There are some things the old CI workflow is building that the new is not, like devnet JS. So I would not suggest removing the old CI until more CI component workflows are created to cover the gap. Maybe the new workflow should be disabled until the others are created? |
@CharlieC3 Ah right. |
Since more workflows are needed for a complete picture, yes. |
@CharlieC3 Will the changes on clarinet dockerfile have impacts on the current CI? |
@hugocaillard Ah good catch, I've updated the old workflow to use the |
@hugocaillard @CharlieC3 What's next on this PR? |
I think just an approval! Let me know if there's something I'm missing @hugocaillard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This new workflow has been disabled for now.
We'll keep using the old one until the workflows have been adapted for other components (mainly stacks-devnet).
The release of clarinet 2 later this year will be a good time to activate it
This reverts commit 5b4dfe8.
Related: #1078
x86_64-unknown-linux-gnu
dist will always get created, others will only run on pushes tomain
anddevelop
branches.dist
job will be skipped for the x86_64-unknown-linux-gnu target, since this target should already be covered in the code coverage job.main
anddevelop
branchesrustup