Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initialize clarinet-sdk with the core js lib #1068

Merged
merged 13 commits into from
Aug 11, 2023
Merged

feat: initialize clarinet-sdk with the core js lib #1068

merged 13 commits into from
Aug 11, 2023

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Jul 5, 2023 •
edited
Loading

Resolve: #1110

$ cd components/clarinet-sdk/
$ npm ci
$ npm build

@hugocaillard hugocaillard force-pushed the feat/clarity-sdk branch 3 times, most recently from 5658715 to 4bdbe13 Compare July 18, 2023 17:25
@hugocaillard hugocaillard force-pushed the feat/clarity-sdk branch 2 times, most recently from b146694 to 7adea91 Compare July 26, 2023 17:16
@hugocaillard hugocaillard changed the title feat: initialize clarinet-sdk with the test-core js lib feat: initialize clarinet-sdk with the core js lib Aug 3, 2023
@hugocaillard hugocaillard marked this pull request as ready for review August 3, 2023 16:21
@hugocaillard
Copy link
Collaborator Author

hugocaillard commented Aug 3, 2023 •
edited
Loading

@MicaiahReid @csgui
I'm marking this PR as ready for review.

The SDK won't be released right after the PR is merged, the idea to keep PRs at reasonable size.

There is still work to do that's not blocking for reviewing/merging

  • testing
  • bundling
  • documenting how to use build the lib

@hugocaillard hugocaillard force-pushed the feat/clarity-sdk branch 4 times, most recently from b4c2e77 to 28b8f7d Compare August 9, 2023 17:30
MicaiahReid
MicaiahReid suggested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I've got a few small comments.

components/clarinet-sdk/README.md Outdated Show resolved Hide resolved
components/clarinet-sdk/src-ts/index.ts Outdated Show resolved Hide resolved
components/clarinet-sdk/cargo.toml Outdated Show resolved Hide resolved
components/clarinet-sdk/webpack.config.js Show resolved Hide resolved
components/clarinet-sdk/webpack.config.js Outdated Show resolved Hide resolved
components/clarinet-sdk/src/utils.rs Outdated Show resolved Hide resolved
components/clarinet-sdk/src/utils.rs Outdated Show resolved Hide resolved
components/clarinet-sdk/src/utils.rs Outdated Show resolved Hide resolved
components/clarinet-sdk/src/utils.rs Show resolved Hide resolved
MicaiahReid
MicaiahReid approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hugocaillard hugocaillard merged commit eb7670e into develop Aug 11, 2023
15 checks passed
@hugocaillard hugocaillard deleted the feat/clarity-sdk branch August 11, 2023 16:04
@hugocaillard hugocaillard mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicaiahReid MicaiahReid MicaiahReid approved these changes

@csgui csgui Awaiting requested review from csgui

@lgalabru lgalabru Awaiting requested review from lgalabru

@janniks janniks Awaiting requested review from janniks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarinet core JS SDK
3 participants
@hugocaillard @lgalabru @MicaiahReid