Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to build with rust 1.80 #631

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

chenrui333
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2024

CLA assistant check
All committers have signed the CLA.

@chenrui333 chenrui333 changed the title chore: upgrade to rust 1.80 chore: upgrade to build with rust 1.80 Aug 1, 2024
@rafaelcr rafaelcr changed the base branch from main to develop August 6, 2024 16:09
@rafaelcr
Copy link
Collaborator

rafaelcr commented Aug 6, 2024

@chenrui333 thanks for this PR, looks very good so far. I've moved the base branch to develop, though, since we'll need to put the change there first. Could you please rebase your branch and fix the conflicts?

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts against develop

@chenrui333
Copy link
Contributor Author

sounds like, let me redo this PR.

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Contributor Author

just resolve the conflicts (it might be worth making develop the default branch)

@rafaelcr rafaelcr merged commit b24ddc6 into hirosystems:develop Sep 17, 2024
1 check passed
Copy link

🎉 This PR is included in version 1.9.0-stacks-signers.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants