chore: update predicate scanning status on every trigger #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
had a problem deploying
to
Development-mainnet
GitHub Actions
Error
MicaiahReid
had a problem deploying
to
Development-testnet
GitHub Actions
Error
csgui
reviewed
Jun 11, 2024
csgui
reviewed
Jun 11, 2024
| @@ -177,6 +183,7 @@ pub async fn scan_bitcoin_chainstate_via_rpc_using_predicate( | |||
| Ok(actions) => { | |||
| if actions > 0 { | |||
| number_of_times_triggered += 1; | |||
| loop_did_trigger = true | |||
There was a problem hiding this comment.
Related to my previous comment: aren't these variables interchangeable?
|
Hey @MicaiahReid ! Not sure if I understand the need of a new control variable. Can't |
MicaiahReid
force-pushed
the
chore/update-status-on-trigger
branch
from
a58f9ee
to
1c73b76
Compare
MicaiahReid
temporarily deployed
to
Development-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-testnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-testnet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predicate status is used to report data to users and to pick back up where the service left off on a restart. This change updates the scanning predicate status to be updated on every successful trigger of a scanning predicate, to be sure we don't scan blocks twice on a restart (if the status was set to a previous block, we'd start on that block at startup)