GitAuto: makeBrowserOfflineTransport no longer adds types to transportOptions #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
Based on the issue description, it seems like there is a bug related to TypeScript type definitions for
transportOptions
in themakeBrowserOfflineTransport
function. Here's the pull request body for addressing this issue:"""
Why the bug occurs
The bug occurs because the
transportOptions
provided tomakeBrowserOfflineTransport
are not correctly typed, leading to a TypeScript error when using options likeflushAtStartup
. The typePartial<BrowserTransportOptions>
does not include theflushAtStartup
property, which is causing the TypeScript validation to fail.How to reproduce
makeBrowserOfflineTransport
function withtransportOptions
that includeflushAtStartup
.Object literal may only specify known properties, and 'flushAtStartup' does not exist in type 'Partial<BrowserTransportOptions>'.
How to fix
To fix this issue, we need to update the type definitions for
transportOptions
in themakeBrowserOfflineTransport
function to include theflushAtStartup
property. This can be done by extending theBrowserTransportOptions
type to include any additional properties that are valid for offline transport options. This will ensure that TypeScript correctly recognizesflushAtStartup
as a valid option, eliminating the error.Test these changes locally