Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/v5-asset-withdraw #165

Merged
merged 2 commits into from
Feb 24, 2024
Merged

feature/v5-asset-withdraw #165

merged 2 commits into from
Feb 24, 2024

Conversation

decanus
Copy link
Contributor

@decanus decanus commented Feb 20, 2024

implements the withdraw endpoint

v5_asset_service.go Outdated Show resolved Hide resolved
v5_asset_service.go Outdated Show resolved Hide resolved
v5_asset_service_test.go Outdated Show resolved Hide resolved
v5_asset_service_test.go Outdated Show resolved Hide resolved
@hirokisan
Copy link
Owner

@decanus Thank you for your commit!

It looks like it needs to be changed. Could you please confirm the contents?

Thanks again.

@decanus
Copy link
Contributor Author

decanus commented Feb 23, 2024

@hirokisan made the necessary changes

Comment on lines +603 to +613
param := V5WithdrawParam{
Coin: CoinETH,
Chain: "ETH",
Address: "0x99ced129603abc771c0dabe935c326ff6c86645d",
Tag: nil,
Amount: "24",
Timestamp: 1672196561407,
ForceChain: true,
AccountType: AccountTypeFunding,
FeeType: 0,
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes must be applied here as well. I will handle this one.

Copy link
Owner

@hirokisan hirokisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@hirokisan hirokisan merged commit 1042ce8 into hirokisan:main Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants