Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE_LOG_JSON_DISABLE_AUTO_PARSE = "false" doesn't work #53

Closed
akefirad opened this issue May 12, 2023 · 1 comment
Closed

CONSOLE_LOG_JSON_DISABLE_AUTO_PARSE = "false" doesn't work #53

akefirad opened this issue May 12, 2023 · 1 comment
Assignees

Comments

@akefirad
Copy link

Simply because:

      if (CONSOLE_LOG_JSON_DISABLE_AUTO_PARSE) { // <-- this one should be === "true"
        parsedObject = JSON.parse(returnData.message); // trim & remove new lines
        parsedObject = JSON.stringify(parsedObject);
      } else {
        parsedObject = JSON.parse(returnData.message);
      }

Not a big issue, but it's a bit confusing since one might try to set it to "false" and it doesn't work. I'd suggest to either fix the code or update the documentation. Happy to send a PR. Thanks.

@hiro5id
Copy link
Owner

hiro5id commented May 16, 2023

Thanks for the observation. When I get the bandwidth ill make that more explicit so that it works. Of course I'm happy to take a code-fix PR as well!

hiro5id added a commit that referenced this issue May 19, 2023
@hiro5id hiro5id closed this as completed May 19, 2023
@hiro5id hiro5id self-assigned this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants