Skip to content

Conversation

@Yianen
Copy link

@Yianen Yianen commented Sep 18, 2025

Upgraded packages for given-est to 30. Updated tests and libraries, fixing breaking changes coming out of the upgrade.

fix #22

Upgraded packages for given-est to 30. Updated tests and libraries, fixing breaking changes coming
out of the upgrade.

fix hirezio#22
@Yianen
Copy link
Author

Yianen commented Sep 19, 2025

@shairez: hey there! could you please take a look at this PR and have it merged/released? Let me know if anything is wrong.
Thanks in advance!

@Yianen
Copy link
Author

Yianen commented Sep 30, 2025

@shairez: Any update on this please? Let me know what needs to be changed, if anything. We have a project with 1000+ tests using this library, and we would prefer to keep using the given/when/then style tests.
Update: the local lint/build/test commands work properly with node 22, I guess it is something CI related?

@shairez
Copy link
Member

shairez commented Sep 30, 2025

Hey yeah I've looked at it looks like more updates needs to happen to all dependencies in order to make it work, which ended up taking more time than I have now.

So if you can do the work of making the CI pass, maybe update the dependencies etc, I can review it, as I don't have the time currently.

You can take a look at what they did here and maybe compare the project setup to save time -

hirezio/auto-spies#88

Upgraded github checkout actions to v3 and setup node steps
Upgraded github checkout actions to v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jest 30 support

2 participants