Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse Validation #33

Merged
merged 15 commits into from
Aug 23, 2024
Merged

Collapse Validation #33

merged 15 commits into from
Aug 23, 2024

Conversation

hipstersmoothie
Copy link
Owner

@hipstersmoothie hipstersmoothie commented Aug 23, 2024 •
edited
Loading

  • When dragging to expand we now validate that the expansion is valid
  • When getting a expandPanel event we validate it can expand
  • During resizing we validate that there is no overflow, when there is we collapse a panel

closes #32

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Aug 23, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-window-splitter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:01am
react-window-splitter-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:01am

@hipstersmoothie hipstersmoothie changed the title Collapse Collapse Validation Aug 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 96.23% 664 / 690
🔵 Statements 96.02% 676 / 704
🔵 Functions 96.32% 157 / 163
🔵 Branches 92.46% 478 / 517
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react-window-splitter/src/index.tsx 89.62% 76.97% 90.9% 89.91% 196-199, 201-220, 202-205, 207-211, 208-210, 209, 213-219, 315, 387, 395, 402, 431, 437, 439-450, 439-441, 443-449, 444-448, 624, 635, 652, 671, 805, 826
packages/state/src/index.ts 99.35% 98.14% 100% 99.55% 1360, 1367, 1379
Generated in workflow #100

@hipstersmoothie hipstersmoothie merged commit e38a0e5 into main Aug 23, 2024
4 checks passed
@hipstersmoothie hipstersmoothie deleted the collapse branch August 23, 2024 06:02
@hipstersmoothie
Copy link
Owner Author

🚀 PR was released in v0.4.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor Increment the minor version when merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collapse Panel Rough Edges
1 participant
@hipstersmoothie