Fix type definition files #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvpeter
commented
Mar 8, 2023
tvpeter
commented
- Bump tiny-secp256k1 library which contains type definition
- add coinselect type definition file.
devmasme
reviewed
Mar 9, 2023
package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "cross-fetch": "^3.1.5", | |||
| "crypto-browserify": "^3.12.0", | |||
| "scrypt-js": "^3.0.1", | |||
| "tiny-secp256k1": "^1.1.6" | |||
| "tiny-secp256k1": "^2.2.1" | |||
There was a problem hiding this comment.
In the past, @ChrisCho-H has downgraded to remove WASM. Please check the commit referenced below. :)
Upgrading packages is usually a good idea, but this code has a specific intent and we should use a lower version this time.
add coinselect type definition file.
devmasme
approved these changes
Mar 9, 2023
|
For React Native, it's cumbersome to handle WASM config, so I deliberately downgraded version to remove WASM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.