Repository navigation
Physical-unit stacking (cm), editable peak markers, custom colors & precise figure sizing - #2
Open
Hongcheng-LI wants to merge 1 commit into
Conversation
…d precise figure sizing - cm-normalized stacking: each curve normalized to a fixed height (default 1 cm) with an adjustable offset in cm; figure height derived from 96dpi so on-screen and exported 1 cm match exactly; curve heights never compress as traces are added - bottom baseline fixed 0.5 cm above the X axis - peak markers: editable numeric labels, adjustable font size, dashed guide line stops at the peak top, no border box - region fills hug each curve down to its baseline (including the All target) with per-region custom colors; per-curve custom colors via color pickers - X range typed numerically instead of a slider; plot area width set in centimeters (excluding label margins); adjustable axis line width and tick font size - migrate legacy set-based marked_peaks to labeled dicts (backward compatible)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文说明
你好！我们此前已联系并获得你的授权，将 HPLC-Data-Visualizer 移植到了我们的学术导航站 SynBioPath 中。在移植和实际使用的过程中，我们把以下改进做了出来，现在把这套改进按上游的代码风格移植回来，希望能回馈给原项目和大家：
主要改进
generate_plot旧参数保持向后兼容English Summary
Ported back a set of improvements we built for the SynBioPath web port (with permission): cm-normalized waterfall stacking with figure height derived at 96dpi (on-screen cm == exported cm, curve heights never compress), editable labeled peak markers whose guide lines stop at the peak top, region fills that hug each curve down to its own baseline with custom colors, per-curve colors, physical plot-area width in cm, and adjustable axis line width / tick font size. Fully backward compatible with the existing
generate_plotAPI and legacy session state.测试 / Testing
期待你的反馈，也欢迎指出哪些地方需要按上游的规划调整！