-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added menu icon to the top right to navigate to the "Settings" screen #97
Conversation
Updated profile screen by adding menu icon to the top right . This issue himanshusharma89#39 was assigned to me and now is resolved.
closes #39 via #97 |
@sakshi2707 Can you create a new file named settings.dart and shift the Settings Widget from profile to the new file in views. Also resolve this conflict for PR to be merged. |
made separate settings.dart and added widget
@himanshusharma89 I've made the respective changes for issue #39 |
It looks good but you need to update your code to resolve the conflicts, do git pull once and resolve the conflicts. Also, you don't need to commit every file on an update, you need to commit once when the task is done. Try to squash the commits to one. If you face any issue do let me know. |
@himanshusharma89 I've resolved all the conflicts. I'm not able to squash the commits into one as I'm a newbie. Please do merge it like this,if possible. Thankyou |
Okay, I'll do that for now, but next time make sure to have not more than 2 commits. |
Before merging can you add the screenshot of the screen, it was mentioned in the PR to do so. |
Actually I have removed the project from my system now. I forgot to take a screenshot, by mistake., sorry for that. So it would be great if you merge my PR ,if possible . Thankyou |
@sakshi2707 Make sure to fix the issue before pushing something next time. |
Updated profile screen by adding menu icon to the top right . This issue #39 was assigned to me and now is resolved.
Related Issue
Proposed Changes
Additional Information
Checklist