Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existent builtins and keywords #1

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

Someon1e
Copy link
Contributor

@Someon1e Someon1e commented Jun 9, 2024

@joshgoebel
Copy link
Member

Are these mistakes or just only apply to older versions of the language?

@Someon1e
Copy link
Contributor Author

Someon1e commented Jun 9, 2024

Are these mistakes or just only apply to older versions of the language?

The ones I removed have never existed in Luau.

@Hexcede
Copy link

Hexcede commented Jun 26, 2024

Are these mistakes or just only apply to older versions of the language?

With the exception of string.dump which was removed from Roblox at some point, I think probably before luau came about, all of that stuff hasn't existed in luau. goto is from lua 5.3 iirc, while luau is based on lua 5.1 and does have backwards compatible backports from lua 5.3 but doesn't implement any of the lower level language features. The rest of the APIs don't exist in luau since it's a very sandboxed language, it's not intended to have access to any operating system stuff out of the box.

Copy link
Collaborator

@robloxiandemo robloxiandemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@robloxiandemo robloxiandemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@robloxiandemo robloxiandemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@robloxiandemo robloxiandemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@robloxiandemo robloxiandemo merged commit 67448bd into highlightjs:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants