Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grammar #3887

Merged
merged 3 commits into from
Oct 15, 2023
Merged

fix grammar #3887

merged 3 commits into from
Oct 15, 2023

Conversation

ShalokShalom
Copy link
Contributor

Fixes articulation and grammar, checked by Grammarly.

@@ -19,7 +19,7 @@ time to time in the Highlight.js issue tracker and discussion group.
This means that *there's no point in requesting a new language without also
providing a 3rd party implementation* (we'll simply close "Please support
language Xyz" issues with a link to this explanation). If you'd like to see
a particular language available but cannot implement it, the best way to
a particular language available that you cannot implement yourself, the best way to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps using "unable" here could be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@github-actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change -8 B

View Changes
file base pr diff
es/core.min.js 8.14 KB 8.13 KB -3 B
es/highlight.min.js 8.14 KB 8.13 KB -3 B
highlight.min.js 8.17 KB 8.17 KB -2 B

@joshgoebel
Copy link
Member

I like this. Is grammarly happy with it?

@github-actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change -3 B

View Changes
file base pr diff
es/core.min.js 8.14 KB 8.14 KB -1 B
es/highlight.min.js 8.14 KB 8.14 KB -1 B
highlight.min.js 8.17 KB 8.17 KB -1 B

@ShalokShalom
Copy link
Contributor Author

Yep :)

ShalokShalom and others added 3 commits October 15, 2023 15:23
@github-actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change -5 B

View Changes
file base pr diff
es/core.min.js 8.14 KB 8.14 KB -2 B
es/highlight.min.js 8.14 KB 8.14 KB -2 B
highlight.min.js 8.17 KB 8.17 KB -1 B

@joshgoebel joshgoebel merged commit e056e2d into highlightjs:main Oct 15, 2023
13 of 14 checks passed
@ShalokShalom ShalokShalom deleted the patch-2 branch October 16, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants