Improve llvm syntax highlighting #3471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Jan 29, 2022
We mention almost all fixes. :) |
- Numbers are allowed to have a leading + sign - Hex floats can have a format specified after the 'x' - Strings cannot escape quotes with backslashes, so a '\"' ends a string
|
Thanks! I fixed your comment and added a changelog entry. (diff of my changes: https://github.com/highlightjs/highlight.js/compare/be47761cb54d2bbeaf16006bb962df1b6f4eecd9..3ee1056de807099140def2e1e362cd6e2ae4853d) |
joshgoebel
approved these changes
Jan 30, 2022
|
|
@Flakebi Thanks so much! |
brainlid
added a commit
to brainlid/highlight.js
that referenced
this pull request
Feb 11, 2022
* master: (816 commits) (chore) add sideEffects: false to enable tree-shaking in esbuild & others fix(markdown) Handle `***Hello world***` without breaking (highlightjs#3457) (chore) DRY up php grammar just a little enh(php) support CSSCase attribute naming refactor, security issues enh(php) Add support for Attributes fix(java) prevent false variable init on `else` (highlightjs#3455) (ci) min change threshold for size report (highlightjs#3401) (themes) Add `tokyo-night-dark` (highlightjs#3467) enh(llvm) Improve number support, add `char.escape` (highlightjs#3471) (chore) simplify brainfuck grammar fix(brainfuck) fix highlighting of initial ++/-- Minor change to TypeScript types and TypeScript-specific keywords (highlightjs#3466) fix(angelscript) Fix highlighting of int8, int16, int32, int64 (highlightjs#3464) enh(php) named arguments and fix php constants (highlightjs#3459) themes: add new felipec theme (highlightjs#3441) (chore) release 10.4.0 enh(arcade) Add missing keywords for Arcade v1.16 chore(arcade) eslint --fix, explode keywords enh(php) Left and right-side of double colon (highlightjs#3422) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
\"ends a stringChecklist
CHANGES.md(it’s a pretty small fix, not sure if this needs to be mentioned?)