Skip to content

Conversation

tebeco
Copy link
Contributor

@tebeco tebeco commented Jun 10, 2021

pwsh is the name of the shell binary for powershell core
powershell is the name of the shell binary for the old deprecated Windows PowerShell

Resolves #3235

Changes

adding pwsh in the alias list of powershell

Checklist

No clue how to do that yet, any hint ?

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

since pwsh is the name of the binary for powershell core (not even supposed to be an alias TBH)
@joshgoebel
Copy link
Member

Nice. Please update changelog.

@tebeco
Copy link
Contributor Author

tebeco commented Jun 10, 2021

@joshgoebel I hope this is what you had in mind

also sorry that I have to ping you sorry as your message was detected as a comment and not a review, I can't use the standard review feature in github:
image

Usually there's a button to "re ask" for review in PR process IIRC, like when review indicate Require Changes

@joshgoebel
Copy link
Member

No need to ping. I see all messages regardless.

@joshgoebel joshgoebel merged commit 40b6a8a into highlightjs:main Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Powershell) Missing detection on PWSH alias

2 participants