-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Clean up linting #2900
(chore) Clean up linting #2900
Conversation
@joshgoebel would you mind giving this another look? |
What is the advantage of JSON again? It's very hard to review because JSON forces every single line to change when really nothing has changed. |
Yes, that's true... though technically there is no reason it couldn't do the same exact thing based on the name of the file and using the default export... but whatever.
Instead of the diff showing what actually changed (a few lines) it just shows 200 lines removed, 200 lines added, etc... making it very hard to review. So I have to scroll thru the file manually comparing one line at a time visually... because I'm pretty sure at first glance you changed a few things and removed some of my comments, etc... And that is why I haven't found the time to sort this out yet. It's on the list to get to though. |
Format workflow YAML to make it valid Restore dev linting of languages Use overrides instead of multiple files Rebase on Master Fix merge html plugin linting Revert ESLint config to js
I've reverted the change to |
OMG, 100x better. Thank you. |
@Hirse Thanks! |
Changes
Switch ESLint config to JSON (for JSON-schema support)npm
lint script to includesrc/plugins
foldermerge_html
pluginlint-languages
npm scriptnpm ci
for faster and more reliable dependency installsnpm lint
scriptstest
andtools
, which are not included in CI, but help during developmentChecklist
CHANGES.md
- NA?